Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VMs used in build CI. #2425

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Update VMs used in build CI. #2425

merged 1 commit into from
Jul 28, 2022

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jul 27, 2022 •
edited
Loading

Fixes build issue brought up in #2424 (comment)

The test CI were already using these OS versions.

@JoeRobich JoeRobich requested review from filipw and 333fred July 27, 2022 16:45
@JoeRobich
Copy link
Member Author

JoeRobich commented Jul 28, 2022 •
edited
Loading

@filipw Can you update the required CI checks? We could switch to running on the -latest images and never have to updates the CI job names, but that opens us up to the image changing underneath us.

@JoeRobich JoeRobich merged commit 4803d17 into master Jul 28, 2022
@JoeRobich JoeRobich deleted the update-build-vms branch July 28, 2022 17:38
@333fred
Copy link
Contributor

333fred commented Jul 28, 2022

I took care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@filipw filipw Awaiting requested review from filipw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeRobich @333fred