Record whether a CodeAction is a fix or not #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omnisharp-roslyn side of fixing dotnet/vscode-csharp#5335.
Rekkonnect
reviewed
Aug 10, 2022
src/OmniSharp.Roslyn.CSharp/Services/Refactoring/V2/AvailableCodeAction.cs
Outdated
Show resolved
Hide resolved
|
Tuples are great for these types of intermediate structure scenarios. |
…e LSP handler code for this into the main handler, and more accurately classify quickfix actions.
|
@JoeRobich @filipw for review please. |
333fred
added a commit
to 333fred/vscode-csharp
that referenced
this pull request
Aug 11, 2022
VSCode side of OmniSharp/omnisharp-roslyn#2430. Fixes dotnet#5335.
333fred
added a commit
to dotnet/vscode-csharp
that referenced
this pull request
Aug 11, 2022
VSCode side of OmniSharp/omnisharp-roslyn#2430. Fixes #5335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omnisharp-roslyn side of fixing dotnet/vscode-csharp#5335.