Register the LanguageServerLogger only once #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Nov 8, 2022
| @@ -62,7 +62,7 @@ public class LanguageServerHost : IDisposable | |||
| .WithInput(input) | |||
| .WithOutput(output) | |||
| // initializeParams from the client won't be arriving yet, configure with app loglevel | |||
| .ConfigureLogging(GetLogBuilderAction(configureLogging, application.LogLevel)) | |||
| .ConfigureLogging(AddLanguageProtocolLogging(application.LogLevel)) | |||
There was a problem hiding this comment.
previously there were two calls to GetLogBuilderAction, one here and one when building the composition (after initialize). Both calls registered the lsp logger and so we got double logs.
I modified this to register the LSP logger initially (with default level) and then configure it on composition building (after initialize).
dibarbet
force-pushed
the
register_languageserverlogger_once
branch
from
b058805
to
3c7c9cc
Compare
333fred
approved these changes
Nov 8, 2022
| private static Action<ILoggingBuilder> GetLogBuilderAction(Action<ILoggingBuilder> configureLogging, LogLevel loglevel) => builder => | ||
| private static Action<ILoggingBuilder> AddLanguageProtocolLogging(LogLevel loglevel) => builder => builder.AddLanguageProtocolLogging().SetMinimumLevel(loglevel); | ||
|
|
||
| private static Action<ILoggingBuilder> ConfigureLogging(Action<ILoggingBuilder> configureLogging, LogLevel loglevel) => builder => | ||
| { | ||
| configureLogging?.Invoke(builder); | ||
| builder |
There was a problem hiding this comment.
Nit: consider joining these lines.
| @@ -178,11 +178,12 @@ private static LogLevel GetLogLevel(InitializeTrace initializeTrace) | |||
| } | |||
| } | |||
|
|
|||
| private static Action<ILoggingBuilder> GetLogBuilderAction(Action<ILoggingBuilder> configureLogging, LogLevel loglevel) => builder => | |||
| private static Action<ILoggingBuilder> AddLanguageProtocolLogging(LogLevel loglevel) => builder => builder.AddLanguageProtocolLogging().SetMinimumLevel(loglevel); | |||
There was a problem hiding this comment.
Nit: consider wrapping this line.
…om/dibarbet/omnisharp-roslyn into register_languageserverlogger_once
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where logs were duplicated when using the LSP version. Logged in dotnet/vscode-csharp#5429