Fix build on macOS Sierra #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjk
suggested changes
Sep 23, 2016
|
really? hmmm... |
|
i think i see where it's failing. |
|
@wjk: I'm installing Sierra now. Want to try again after my last tweak? |
|
nevermind. this won't fix it yet. The problem is that OmniSharp is using |
|
OK. Fingers crossed. Works on my (macOS Sierra) machine. |
DustinCampbell
force-pushed
the
fix-macos-build
branch
from
d524b68
to
cb15553
Compare
|
Note: Adding all of the runtimes to the test projects (+ an extra one for AppVeyor) feels just awful. Does anyone have any better ideas here? |
wjk
approved these changes
Sep 24, 2016
|
Thanks, that fixes my issue! 😸 ❤️ |
It turned out that the OmniSharp.Tests was defined incorrectly. It was a netcoreapp1.0, but wanted to act like a library.
DustinCampbell
changed the title
david-driscoll
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643
This should fix builds on macOS Sierra.
There were a couple of problems that needed fixing due to runtime packages not being available for macOS Sierra (osx.10.12-x64).
dotnet restore --infer-runtimes. Since there aren't runtime packages for macOS Sierra, it failed. We actually don't to specify this any longer, so I removed the flag.dotnet publishneeds to specify a runtime on macOS Sierra. Otherwise, it will specify the current runtime (osx.10.12-x64), which doesn't exist. So, the build script now detects the current RID by looking at the output ofdotnet --info. Then, in the publish step, the build script checks to see if the current RID isosx.10.12-x64when attempting to publish for "default" and usesosx.10.11-x64instead.