Added an .editorconfig to dictate project formatting settings

[Mpdreamz]

Every editor under the sun supports (or should!) http://editorconfig.org/

Visual studio has an extension: https://visualstudiogallery.msdn.microsoft.com/c8bccfe2-650c-4b42-bc5c-845e21f96328

This will force your editor settings to be changed when working on our project to the settings we dictate.

Editorconfig will leave your defaults alone, so when you switch back to a private project with no editorconfig file it will keep using your default settings there.

Ties into #70

[nosami]

kproj files are indented by 2 spaces. I don't think anyone would ever edit those, but it should probably be added.

[khellang]

I think corefx's .editorconfig makes sense. Maybe something like:

# EditorConfig is awesome: http://EditorConfig.org

root = true

[*]
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 2

[*.cs]
indent_size = 4

[nosami]

@khellang looks good to me.

[Mpdreamz]

👍 thanks @khellang will update the PR shortly

That url should also be quoted though, even if editorconfig files can handle invalid keys (part of its test suite).

[Mpdreamz]

Updated, do we care about squashing and rebasing?

[nosami]

nah! thanks!

[jrieken]

👍

[jrieken]

@Mpdreamz didn't you also do an API (editor config nuget package) so that we can seed the roslyn formatter with those settings?

[Mpdreamz]

I did, I just updated it today so that it includes a proper aspnetcore50 build in the nuget package. Just did a git checkout -b feature/editorconfig-powered-formatting to start on #31 :)

[Mpdreamz]

It wont actually seed once though, it will lookup everytime since thats the editorconfig way, i.e you might very well have different settings for *.generated.cs vs *.cs files.

Usually an editor opens a file and seeds that file with editorconfig settings, but we dont track editors opening and closing files on the server right? or do we?

[jrieken]

yeah - that's what I meant. we should have a thing (service?) which returns an OptionSet that applies to the current file.