Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unsafe in C# scripts #781

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Conversation

filipw
Copy link
Member

@filipw filipw commented Feb 21, 2017

At the moment C# script compiler APIs in Roslyn implicitly always allows unsafe blocks.
OmniSharp should match that because at the moment we break when defining i.e.

unsafe void Print(string txt) {
  // do stuff
}

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DustinCampbell
Copy link
Contributor

Totally.

@filipw filipw merged commit b55c25f into OmniSharp:dev Feb 22, 2017
@filipw filipw deleted the feature/allowunsafe-script branch February 22, 2017 07:05
@filipw
Copy link
Member Author

filipw commented Feb 22, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants