Ensure that MSBuildProjectSystem doesn't add project references twice #815
Conversation
It's possible for project references to appear twice within an MSBuild project after execution: * As a ProjectReference item * As a ReferencePath item with ReferenceSourceTarget="ProjectReference" This change makes sure that ReferencePath items that were sourced from project references aren't added. We just use the project references, which is a better experience at designtime when the project is built.
|
have you thought of publishing all this MSBuild-related code as a nuget package? For example I would like to use something like that in other projects - being able to go from |
Probably not. We already have that in Roslyn with the MSBuildProjectLoader. It just doesn't work with the latest MSBuild and isn't portable. However, it's looking likely that I'll be called upon to fix that. |
|
oh that's what I've been missing. Is it part of any of the Roslyn nuget packages? |
|
Sure, but it's only available on desktop: https://www.nuget.org/packages/Microsoft.CodeAnalysis.Workspaces.Common/. The API sits next to MSBuildWorkspace. |
|
thanks! |
Fixes #795
It's possible for project references to appear twice within an MSBuild project after execution:
This change makes sure that ReferencePath items that were sourced from project references aren't added. We just use the project references, which is a better experience at designtime when the project is built.
Note: There was code that used to do this, but it was unintentionally removed in a refactoring a few months ago (by me -- oops!): ef4b383.