Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of fixes to test support #945

Merged
merged 7 commits into from
Aug 20, 2017

Conversation

DustinCampbell
Copy link
Contributor

Fixes #942 and #944

  • When running a test via 'dotnet vstest' support, pass "--no-restore" when building with the .NET CLI to ensure that implicit restore does not run, making build a bit faster.
  • Add support for specifying the 'TargetFrameworkVersion' to the 'dotnet vstest' endpoints.

@@ -4,6 +4,8 @@ All changes to the project will be documented in this file.
## [1.24.0] - Not released

* Fixed a bug where an external code action DLL with missing dependencies would crash OmniSharp.
* When running a test via 'dotnet vstest' support, pass "--no-restore" when building with the .NET CLI to ensure that implicit restore does not run, making build a bit faster. ([#942](https://github.com/OmniSharp/omnisharp-roslyn/issues/942))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good!

@david-driscoll david-driscoll merged commit 78ccc8b into OmniSharp:master Aug 20, 2017
@DustinCampbell DustinCampbell deleted the vstest-improvements branch August 30, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants