-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to newer MSBuild on macOS for .NET6 workload resolver support #4417
Comments
the bundled MSBuild was updated to 16.9 yesterday to match .NET 6 Preview 1 We plan to release a new version of OmniSharp server today |
Thanks @filipw ! What's the path to using that update in vscode once the server update is released? Is there a way I can help test? |
you can set |
@filipw I've updated and I'm still having trouble getting it to pick up the new workload resolver. This was the same for 1.37.7 on another Mac, even though this one I've got the 1.37.8-beta2 (I did check to verify MSBuild from 16.9 series on 1.37.8-beta2). I'm trying to load a project from this repo: https://github.com/dotnet/net6-mobile-sample The workload resolver is supposed to be enabled by adding the file in the sdk, for example:
For some reason it's not picking it up and so the TargetPlatformIdentifier Here's my omnisharp logs:
|
@JoeRobich I installed the maui rc2 workload on MacOS. On vscode, Omnisharp does not seem to be resolving platform specific using directives, with errors like:
Could you confirm if omnisharp currently supports maui projects, and if not, when can we hope to have that support? I've opted-in to use the latest server version. Right now, it is: Thanks! |
@cfierro-glb I was able to get the WeatherTwentyOne sample app loaded with no error on my M1 Mac by performing the following steps (referencing https://github.com/dotnet/maui/wiki/macOS-Install).
{
"sdk": {
"version": "6.0.300"
}
}
- global using Microsoft.Maui.Essentials;
+ global using Microsoft.Maui.Devices;
+ global using Microsoft.Maui.ApplicationModel; Maybe you can see if it will load for you as well. |
@JoeRobich Thanks for your response. I did all the steps before, but missed the one that fixed my issue: With this in mind, are there plans for O# to load all targets of a multi-target projects in the future? |
It is certainly a highly requested feature - #3754. I think long term we will need better support for it. We will just have to see how that gets worked into the road map. |
Thanks for the link. I've subscribed for any updates |
Currently on macOS (and presumably Linux) OmniSharp cannot resolve optional workloads in .NET 6.
The version of MSBuild shipping with mono does not have this support (and likely never will). I see that the extension also bundles its own version of MSBuild (which appears to be from VSWin?).
It would be great if this could be updated to align with the MSBuild in VS 16.9 so that the workload resolvers can be enabled to support resolving SDK's from optional workloads to include additional TFM's such as net6.0-android and net6.0-ios.
Today, this is achieved by adding a sentinel file to the right location in the SDK, for example:
You can find more about how to install the SDK workloads for iOS/Android here:
https://github.com/dotnet/net6-mobile-samples
The text was updated successfully, but these errors were encountered: