Add/update 'omnisharp.useGlobalMono' option #2244
Merged
+267
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
==========================================
+ Coverage 59.75% 59.88% +0.13%
==========================================
Files 77 77
Lines 3762 3772 +10
Branches 545 550 +5
==========================================
+ Hits 2248 2259 +11
- Misses 1341 1342 +1
+ Partials 173 171 -2
Continue to review full report at Codecov.
|
DustinCampbell
force-pushed
the
tweak-useMono-option
branch
from
da04dcd
to
5b40b39
Compare
This change updates the name of the 'omnisharp.useMono' option to 'omnisharp.useGlobalMono', and makes it a tri-state value rather than a boolean. It now has three possible values: * "auto": Launch OmniSharp on the globally-installed Mono if it's available. * "always": Always try to launch OmniSharp on the globally-installed Mono and error if it's not available. * "never": Never launch OmniSharp on the globall-installed Mono.
DustinCampbell
force-pushed
the
tweak-useMono-option
branch
from
5b40b39
to
8bb7c30
Compare
DustinCampbell
force-pushed
the
tweak-useMono-option
branch
from
8bb7c30
to
510b7cd
Compare
rchande
approved these changes
May 1, 2018
akshita31
approved these changes
May 1, 2018
|
@DustinCampbell Since this is user-facing change should there be an update to the ChangeLog as well ? |
|
Yes there should. Thanks! |
|
@DustinCampbell Should we also update the test-plan.md (https://github.com/OmniSharp/omnisharp-vscode/blob/master/test-plan.md#omnisharpusemono-for-linux) in accordance with these changes. |
|
@akshita31 : Yes, it needs updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the name of the 'omnisharp.useMono' option to 'omnisharp.useGlobalMono', and makes it a tri-state value rather than a boolean. It now has three possible values: