Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding publish task description by default for initial assets #2903

Merged
merged 5 commits into from
Mar 15, 2019
Merged

Adding publish task description by default for initial assets #2903

merged 5 commits into from
Mar 15, 2019

Conversation

timheuer
Copy link
Member

This is part of the step to resolve #2874 which adds publish to the default assets created. This is needed to support things like appService.preDeployTask integration more seemlessly for .NET developers.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2903 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2903   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          59       59           
  Lines        1581     1581           
  Branches       89       89           
=======================================
  Hits         1421     1421           
  Misses        149      149           
  Partials       11       11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c5a05...0a7aef2. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2903 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2903   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          59       59           
  Lines        1581     1581           
  Branches       89       89           
=======================================
  Hits         1420     1420           
  Misses        149      149           
  Partials       12       12
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c857a35...c7a8bf9. Read the comment docs.

Copy link

@rchande rchande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rchande
Copy link

rchande commented Mar 13, 2019

@timheuer What's the user experience like with the watch command you added? I'm wondering how VSCode handles tasks where the command doesn't terminate. Is there a way for you to kill it yourself?

@timheuer
Copy link
Member Author

@rchande this launches a terminal command and will ‘wait’ with the ability to terminate (it outputs the message to terminate) with a CTRL+C

@rchande
Copy link

rchande commented Mar 15, 2019

@timheuer Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should support tasks for public and watch
3 participants