Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call updateBuffer if there are no changes. #4170

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

JoeRobich
Copy link
Member

As mentioned in this issue, microsoft/vscode#50344, the onDidChangeTextDocument callback is invoked when a document has changed as well as when its state has changed between 'dirty' and 'clean'.

When it is invoked as a state change there will be no changes and there is no need to call updateBuffer.

Copy link
Contributor

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only a hack if we don't call it a workaround 🙂

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #4170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4170   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
integration 100.00% <ø> (ø)
unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4dd35...9d9e5fa. Read the comment docs.

@JoeRobich JoeRobich merged commit f2ea93f into dotnet:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants