Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cbuild2cmake] Give the build step access to the terminal #175

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[cbuild2cmake] Give the build step access to the terminal #175

merged 1 commit into from
Aug 27, 2024

Conversation

brondani
Copy link
Collaborator

@github-actions GitHub Actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-actions GitHub Actions
Copy link
Contributor

Test Results

  4 files  ±0   20 suites  ±0   1s ⏱️ ±0s
 69 tests ±0   69 ✅ ±0  0 💤 ±0  0 ❌ ±0 
276 runs  ±0  276 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9fc3c00. ± Comparison against base commit e3a14c7.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Aug 27, 2024

Code Climate has analyzed commit 9fc3c00 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.7% (0.0% change).

View more on Code Climate.

@brondani brondani marked this pull request as ready for review August 27, 2024 13:17
@brondani brondani requested a review from soumeh01 August 27, 2024 13:17
jkrech
jkrech approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - matches the proposed solution stated in the corresponding issue.

@jkrech jkrech merged commit 04f45dd into main Aug 27, 2024
16 checks passed
@jkrech jkrech removed the request for review from soumeh01 August 27, 2024 13:19
@brondani brondani deleted the improve-build-output branch December 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrech jkrech jkrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brondani @jkrech