Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild2cmake] Reduce default verbosity of database step #239

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

brondani
Copy link
Collaborator

@brondani brondani commented Dec 13, 2024

Fixes

Changes

  • By default do not print database step message. Verbose messages are enabled in debug mode.

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

Test Results

  4 files  ±0   20 suites  ±0   2s ⏱️ ±0s
 74 tests ±0   74 ✅ ±0  0 💤 ±0  0 ❌ ±0 
296 runs  ±0  296 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c8d9c44. ± Comparison against base commit 48818d0.

Copy link

codeclimate bot commented Dec 13, 2024

Code Climate has analyzed commit c8d9c44 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0%.

View more on Code Climate.

@brondani brondani marked this pull request as ready for review December 13, 2024 09:21
@brondani brondani requested a review from jkrech December 13, 2024 09:21
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit 9a4a85b into main Dec 13, 2024
16 checks passed
@brondani brondani deleted the database-reduce-verbosity branch December 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants