Fix write-protection in CMSIS_PACK_ROOT #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 69.93% 70.00% +0.06%
==========================================
Files 7 7
Lines 662 690 +28
==========================================
+ Hits 463 483 +20
- Misses 199 207 +8 ☔ View full report in Codecov by Sentry. |
The check_pack function downloads missing dependency pdsc files into the CMSIS_PACK_ROOT/.Web folder. This download fails if the CMSIS_PACK_ROOT has write-protection enabled as done by cpackget for example. This fix considers the write-permission.
JonatanAntoni
force-pushed
the
write-protect
branch
from
8718dea to
a843b58
Compare
|
Code Climate has analyzed commit a843b58 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_packfunction downloads missing dependency pdsc files into theCMSIS_PACK_ROOT/.Webfolder. This download fails if theCMSIS_PACK_ROOThas write-protection enabled as done bycpackgetfor example. This fix considers the write-permission.