Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.18.0 🎉 #425

Merged
merged 60 commits into from
Jan 14, 2025
Merged

v0.18.0 🎉 #425

merged 60 commits into from
Jan 14, 2025

Conversation

simonmicro
Copy link
Member

@simonmicro simonmicro commented Jan 11, 2025 •
edited
Loading

After #423, #424

RuffaloLavoisier and others added 18 commits October 23, 2024 13:09
@RuffaloLavoisier
Resize Time and Date data type size
bcde413
@RuffaloLavoisier
workflows: upload firmware binary
160a01c
@RuffaloLavoisier
workflows: upload firmware binary (#419)
752ef0a
@RuffaloLavoisier
workflows: upgrade artifact version to v4
d3eec13
@RuffaloLavoisier
workflows: rename artifact to specific model type
db0ecc2
@RuffaloLavoisier
workflows: upgrade artifact version to v4 (#420)
2cc0a02 
fix #421
@simonmicro
corrected troubleshooting link
02a65b8 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Reimplemented display+bl init order to prevent flashing
0cb87ae 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Interaction on unlocked console also counts as user interaction
d78edf0 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Also reset fonts upon redraw
f4041b7 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Toast on default watchface change
d2512c8 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Added "dd/mm/yyyy" as date format
3117ea3 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Add note how to use default buttons
0bc41af 
Signed-off-by: simonmicro <[email protected]>
@simonmicro
Fixed select button bug on analog+fitness watchface
f3e07c5 
Signed-off-by: simonmicro <[email protected]>
@RuffaloLavoisier
OswAppWatchfaceDigital: resize date type
ed032c9 
- year, month and day
@RuffaloLavoisier
Resize time data type for time structure
ea1b121 
- hour, minute, second
@simonmicro
Resize Time/Date date type (#401)
97fe4ed
@simonmicro
Fixed broken time on watchface
7c1f12d 
Signed-off-by: simonmicro <[email protected]>
@simonmicro simonmicro added 🐞 bug Something isn't working ⭐ enhancement New feature or request src/osw-app This PR / issue impacts the current release of the OS src/core src/osw-service 📜 documentation This adds / changes the documentation 🎉 release This PR / issue impacts the current release of the OS connection/Bluetooth labels Jan 11, 2025
@simonmicro simonmicro self-assigned this Jan 11, 2025
@simonmicro simonmicro added this to the v0.18.0 milestone Jan 11, 2025
RuffaloLavoisier and others added 13 commits January 12, 2025 12:31
@simonmicro simonmicro marked this pull request as ready for review January 12, 2025 20:54
@RuffaloLavoisier RuffaloLavoisier self-requested a review January 12, 2025 22:25
RuffaloLavoisier
RuffaloLavoisier requested changes Jan 12, 2025
View reviewed changes
src/services/OswServiceTaskConsole.cpp Show resolved Hide resolved
src/osw_config_keys.cpp Show resolved Hide resolved
include/apps/watchfaces/OswAppWatchfaceDigital.h Outdated Show resolved Hide resolved
include/services/OswServiceTaskBLEServer.h Show resolved Hide resolved
include/services/OswServiceTaskBLEServer.h Show resolved Hide resolved
include/services/OswServiceTaskBLEServer.h Show resolved Hide resolved
include/services/OswServiceTaskBLEServer.h Show resolved Hide resolved
include/services/OswServiceTaskBLEServer.h Show resolved Hide resolved
@simonmicro
Address review comments
c323002 
Signed-off-by: simonmicro <[email protected]>
RuffaloLavoisier
RuffaloLavoisier requested changes Jan 14, 2025
View reviewed changes
src/apps/watchfaces/OswAppWatchfaceFitnessAnalog.cpp Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceDigital.cpp Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceFitnessAnalog.cpp Outdated Show resolved Hide resolved
src/apps/watchfaces/OswAppWatchfaceDigital.cpp Outdated Show resolved Hide resolved
@simonmicro
Copy link
Member Author

simonmicro commented Jan 14, 2025 •
edited
Loading

Good point. I'll take a look into it later. But, for next time, shouldn't we catch and discuss this earlier? Like on the PR initially introducing this and then failing to integrate? Sorry, a little frustrated, because I wanted to merge this Monday.

@RuffaloLavoisier @simonmicro
Fix compile waring
a6ba489 
- Move variables that are compiled but may not be used due to macros into the scope of the macros.
@simonmicro
Copy link
Member Author

simonmicro commented Jan 14, 2025 •
edited
Loading

Sorry for the force - I feel like its Monday again... 😑

RuffaloLavoisier
RuffaloLavoisier approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@RuffaloLavoisier RuffaloLavoisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@simonmicro simonmicro added the ✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished label Jan 14, 2025
@RuffaloLavoisier RuffaloLavoisier merged commit cf10dd6 into master Jan 14, 2025
243 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuffaloLavoisier RuffaloLavoisier RuffaloLavoisier approved these changes

Assignees

@simonmicro simonmicro

Labels
connection/Bluetooth ✔️ merge when CI passed Note for the maintainers: Merge the PR ASAP after the CI finished 🐞 bug Something isn't working 📜 documentation This adds / changes the documentation src/core src/osw-app This PR / issue impacts the current release of the OS src/osw-service ⭐ enhancement New feature or request 🎉 release This PR / issue impacts the current release of the OS
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonmicro @RuffaloLavoisier @actions-user