Maksbotan/fix domstream clicks play #822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
/path/to/php cli.php cmd=build
) was run locally and any changes were pushedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
I've fixed all problems related to clicks in DOM streams that were bugging me. Specifically:
$.animate
usageclickEventHandler
, this is due to missingjGrowl
id
orname
attributes. Now it first tries to click on node based on its coordinatesIssue Number: #819
What is the new behavior?
IMO, DOM streams are recorded and played correctly.
Does this introduce a breaking change?
Docs need to be updated?
Other information