Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maksbotan/fix domstream clicks play #822

Conversation

maksbotan
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tested the changes
  • Build (/path/to/php cli.php cmd=build) was run locally and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

What is the current behavior?

I've fixed all problems related to clicks in DOM streams that were bugging me. Specifically:

  1. DOM stream player was playing clicks and mouse moves out of order, this is related to wrong $.animate usage
  2. DOM streams sometimes were not saved, this is related to double url-encoding of POST data
  3. DOM stream player was throwing error in clickEventHandler, this is due to missing jGrowl
  4. DOM stream player could click only on DOM nodes with either id or name attributes. Now it first tries to click on node based on its coordinates

Issue Number: #819

What is the new behavior?

IMO, DOM streams are recorded and played correctly.

Does this introduce a breaking change?

  • Yes
  • No

Docs need to be updated?

  • Yes
  • No

Other information

Browser does this encoding automatically, so doing it in our code
results in double-encoded strings, which breaks later processing.
$.animate() in moveCursor was passing animation completion callback
incorrectly.
@padams
Copy link
Collaborator

padams commented Jan 1, 2023

Look good. will merge now.

@padams padams merged commit 1fa28ad into Open-Web-Analytics:master Jan 1, 2023
@padams padams added this to the 1.7.8 milestone Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants