Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow install via composer #5

Merged
merged 7 commits into from
Sep 12, 2021
Merged

allow install via composer #5

merged 7 commits into from
Sep 12, 2021

Conversation

daemon-byte
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tested the changes

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

What is the current behavior?

you have to download a tarball and unzip it
Issue Number: N/A

What is the new behavior?

you now use composer require

Does this introduce a breaking change?

  • Yes
  • [x ] No

It's possible the old method doesn't work anymore. I can't test that with my setup but it should be easily fixed if that's the case.

Docs need to be updated?

  • Yes
  • No

I already updated it

Other information

@padams
Copy link
Contributor

padams commented Sep 8, 2021

@daemon-byte It looks like a commit slipped in before this. can you resolve the conflict? I'll merge today.

# Conflicts:
#	src/Tracker/TrackerClient.php
@daemon-byte
Copy link
Contributor Author

I pulled your master into mine and dealt with the conflict so that should work now? I'm new to contributing back to forks

@padams
Copy link
Contributor

padams commented Sep 9, 2021

@daemon-byte No worries. you are doing great. one more change is needed though.

owa-autoloader.php is needed for people that do not use composer to install this SDK. So we actually need to leave that file where it is and not move it into the src/ directory. Also the class paths in that file need to be changed to reflect the new location of the files or... i suppose we could remove that autoloader entirely now that composer is doing the full autoloading. I can test that after you land this.

@daemon-byte
Copy link
Contributor Author

It's not needed because of composer but let me have a quick play with it today. Maybe I can find a way to keep the legacy method as an option without pushing people into using composer. Options are good

@padams
Copy link
Contributor

padams commented Sep 10, 2021

Yeah i think its important for backward compatibility.

@daemon-byte
Copy link
Contributor Author

daemon-byte commented Sep 10, 2021

ok so I moved the file back and updated it so you can use the old method or ignore the file and use composer. My test syytem was php 8.0 so I fixed a couple of depreciated errors as well. There was also 1 function where the group and name were the wrong way around vs the documentation so I fixed that as well. I made sure they were seperate commits so you can choose which to take

@padams padams merged commit 648f150 into Open-Web-Analytics:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants