-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow install via composer #5
Conversation
@daemon-byte It looks like a commit slipped in before this. can you resolve the conflict? I'll merge today. |
# Conflicts: # src/Tracker/TrackerClient.php
I pulled your master into mine and dealt with the conflict so that should work now? I'm new to contributing back to forks |
@daemon-byte No worries. you are doing great. one more change is needed though.
|
It's not needed because of composer but let me have a quick play with it today. Maybe I can find a way to keep the legacy method as an option without pushing people into using composer. Options are good |
Yeah i think its important for backward compatibility. |
ok so I moved the file back and updated it so you can use the old method or ignore the file and use composer. My test syytem was php 8.0 so I fixed a couple of depreciated errors as well. There was also 1 function where the group and name were the wrong way around vs the documentation so I fixed that as well. I made sure they were seperate commits so you can choose which to take |
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
you have to download a tarball and unzip it
Issue Number: N/A
What is the new behavior?
you now use composer require
Does this introduce a breaking change?
It's possible the old method doesn't work anymore. I can't test that with my setup but it should be easily fixed if that's the case.
Docs need to be updated?
I already updated it
Other information