-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nested lists in property values #284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 70.53% 70.53%
=======================================
Files 369 369
Lines 93428 93428
=======================================
Hits 65902 65902
Misses 27526 27526
Continue to review full report at Codecov.
|
Thanks for the patch. |
Can you test again? For some reasons the first automated build was successful, but now there is a failure that I cannot explain. Thanks |
I can reproduce the failure when using the build script with
However, if I do as what I did previously then the tests can pass:
I'm testing with a few more configurations to see where the problem might be. |
Thanks. As a general rule, please compile with --enable-debug |
This pull request enables the support for the use of nested lists in property values.
As suggested in Issue #282, the implementation is based on the idea to change
Property_List_Value
fromList_Id
toNode_Id
.A few things to note and check when reviewing the pull request are:
To minimize the impact on the existing code base, I keep
Multi_Value
andExpanded_Multi_Value
asList_Id
so that the existing handling for the property values with just a single-layer list is not impacted. The second and above layer nested lists, if existed, will be stored asK_Property_List_Value
nodes in their previous layer's list nodes as intended.The support for nested lists is also implemented in the
aadl
backend which benefits the test (/tests/github/issue_282/test.aadl
) for this pull request.The output for the test
tests/real-annexes-execution/test_real_exec_02.aadl
is revised based on my understanding that the correction is necessary and the difference is due to the change for the structure ofProperty_List_Value
. It would be appreciated if you can verify this test output in particular.