Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that fails to initialize a variable #285

Closed
wants to merge 1 commit into from

Conversation

nvcyc
Copy link
Contributor

@nvcyc nvcyc commented Feb 6, 2021

The uninitialized variable Success leads to a failure when analyzing the nested lists in property values.
This patch fixes the initialization as it is supposed to be.

Note that this patch is related to the feature stated in #282.

@yoogx
Copy link
Contributor

yoogx commented Feb 6, 2021

Merged manually

@yoogx yoogx closed this Feb 6, 2021
@nvcyc
Copy link
Contributor Author

nvcyc commented Feb 6, 2021

Thanks for handling the pull request.
Do you know why all 4 automatic checks failed in this pull request while the same checks seem to pass after the commit is merged?
Do you consider the original problem is resolved by this patch or is it something we need to dig further?

@yoogx
Copy link
Contributor

yoogx commented Feb 6, 2021

I have no idea why they passed then failed. This is something i have to consider.
At this stage you had addressed the issue in the declarative model. I suspect more would be required during instantiation. This will be discovered when you implement you own tool based on Ocarina API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants