Update Installation Script for Windows (powershell) #312
Conversation
|
Also we should note that our |
|
Thanks @KrishPatel13 !
Can you please clarify? Was this a local issue, or is there an error that you get on a fresh install? |
|
It is on a fresh install. For everyone. |
|
@KrishPatel13 can you please fix it and submit a PR? 🙏 |
|
Thank you @KrishPatel13 ! Separate PR is not needed. Is this ready for review? |
|
@abrichr Yes, it is ready for review! After this is merged, we can also merge the below PR: |
|
@dianzrong Thank you for your review. From #312 (comment) I would like to ask @abrichr, if this approach is vaible or not. Also somewhere I do not feel to ask for input from User as our ultimate goal is "One-Click (or press Enter) Install. Any thought @dianzrong ? 🤔 |
|
@abrichr Ready for Merging! |
@dianzrong Thank you !! |
|
Trying to test again on VM, but gave same issue |
|
@abrichr Ready for Review! |
* test only tesseract * test only tesseract * test tesseract only * uncomment the last line * try to redirect * change the description for failed message * add OCR * test python * format function calling * Update Description * prepare for git test * test Git * update the VSCppRedistCMD * using Write-Host * Use ';' for the return command * full test * add description for all arguments * test tesseract on pc with out it * fix order for the installtion * uncomment the remove-gitinstaller * Stop deletion of Openadapt if the pytest fails * add the Cleanupfailure parameter to the apt comman * make user oriented messages * rewrite comments * do not exit on pytest fail * remove VS C++ Redistributable * remove VS C++ installtion consts * fix pytest fail exit * redirect the output to null * rename the param * remove unneccessary line * try a new powershell window for poetry shell * add colours to messages * try to fix NSIS error * fix file name * different approach to fix NSIS * different approach to fix tesseract * try to fic NSIS error * try to fix NSIS error * remove line * remove uneccssary comment * remove unsupported dcostrings * remove unused arugs * redirect output to null * ran `poetry lock --no-update` to fix the warning * Address comment: OpenAdaptAI#312 (comment) * Address comment: OpenAdaptAI#312 (comment) * Address comment: OpenAdaptAI#312 (comment) * imporve resuability and readability * remove redirection to null
What kind of change does this PR introduce?
Summary
Checklist
How can your code be run and tested?
In Powershell: run the below command: (If Prompted, click 'Yes'):
Start-Process powershell -Verb RunAs -ArgumentList '-NoExit', '-ExecutionPolicy', 'Bypass', '-Command', "iwr -UseBasicParsing -Uri 'https://raw.githubusercontent.com/KrishPatel13/OpenAdapt/test/install/install/install_openadapt.ps1' | Invoke-Expression"Other information