-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add capture.py - also fixes audio recording #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Than you @0dm! Any thoughts on how to implement this on Windows? Do you have a Windows machine you can use? |
@abrichr I can try working on a Windows version (win32) using Parallels. |
7 tasks
abrichr
reviewed
Aug 28, 2023
abrichr
reviewed
Aug 28, 2023
abrichr
reviewed
Aug 28, 2023
abrichr
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
R-ohit-B-isht
pushed a commit
to R-ohit-B-isht/OpenAdapt
that referenced
this pull request
Jun 21, 2024
* merge * Create capture.py * Update capture.py * Update capture.py * it's finally fixed * add dependencies * comment * move code + use config.CAPTURE_DIR_PATH * remove debug lines * Update capture.py * OpenAdaptCapture -> Capture * add camera * Let's have this off by default. * hotfix * fix * linting * Create capture.py * windows * cleanup + lint * Update _windows.py * add audio + new windows recording * screen_recorder.free_resources() * Update _windows.py * isort * add playback recording * Update replay.py * Update replay.py * Update README.md * Revert "Update README.md" This reverts commit 7064103. * Update README.md * Revert "Revert "Update README.md"" This reverts commit 0fe8156. * Update README.md * run pre-commit * Update pyproject.toml * Update openadapt/replay.py * Update openadapt/replay.py * Update openadapt/replay.py * Update replay.py * update poetry.lock --------- Co-authored-by: Richard Abrich <[email protected]> Co-authored-by: Richard Abrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a new module - capture for macOS. This allows for easy screen + audio recording.
bugfix: we can now record audio while also recording window states.
Summary
motivation: i dug through apple's api for what felt like ages
creating this allowed me to easily debug and find the cause of the error getting focused window bug - closes #183
this is also useful if we ever need a recording.
Checklist
How can your code be run and tested?
demo: https://streamable.com/5a09ym
captured via capture.py
you can clearly hear the audio!
Other information