fix(coresmd): trim quotes on cert path to actually ignore if empty #5
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing '' or "" as an empty argument would see the cert path be literally quotes (e.g. "" or ''). This commit ensures those characters are trimmed from the output (shallowly) so the string appears as empty when checking if the cert path is set.
|
@rainest Your second bullet in your comment here mentioned having to put in a fake certificate when operating SMD without TLS. Specifying the CA certificate path was always meant to be optional, so I took a look and found that specifying empty quotes wasn't being picked up as an empty argument so that is fixed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing '' or "" as an empty argument would see the cert path be literally quotes (e.g. "" or ''). This PR ensures those characters are trimmed from the output (shallowly) so the string appears as empty when checking if the cert path is set. The certificate path should be optional and this PR ensures that that is enforced.