Skip to content

Commit

Permalink
Set server_version in dbal config
Browse files Browse the repository at this point in the history
See: doctrine/DoctrineBundle#351 for more
details about the problem.
  • Loading branch information
MKodde committed Sep 19, 2018
1 parent 2d13c66 commit d719bca
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ branches:
only:
- master
- develop
- release/2.9
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 2.9.1
**Bugfix**
* Resolve a Doctrine DBAL configuration issue described in https://github.com/doctrine/DoctrineBundle/issues/351

## 2.9.0
**Bugfix**
* Fix SRAA command for institution without config #228
Expand Down
3 changes: 3 additions & 0 deletions app/config/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ doctrine:
dbname: "%database_middleware_name%"
user: "%database_middleware_user%"
password: "%database_middleware_password%"
server_version: '5.6'
charset: UTF8
gateway:
driver: "%database_driver%"
Expand All @@ -80,6 +81,7 @@ doctrine:
dbname: "%database_gateway_name%"
user: "%database_gateway_user%"
password: "%database_gateway_password%"
server_version: '5.6'
charset: UTF8
deploy:
driver: "%database_driver%"
Expand All @@ -88,6 +90,7 @@ doctrine:
dbname: "%database_middleware_name%"
user: "%database_deploy_user%"
password: "%database_deploy_password%"
server_version: '5.6'
charset: UTF8
types:
authority_role: Surfnet\StepupMiddleware\ApiBundle\Doctrine\Type\AuthorityRoleType
Expand Down

4 comments on commit d719bca

@tvdijen
Copy link
Contributor

@tvdijen tvdijen commented on d719bca Sep 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not a placeholder that can be set in parameters.yml instead of hardcoding the version here?

@MKodde
Copy link
Member Author

@MKodde MKodde commented on d719bca Sep 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this was a 'get the Travis build to pass fix' and you are absolutely right, this should be configurable. Adding this to my todo list! Is this something that breaks your way of installing Stepup release 16? Or will it be fine to fix it for release 17?

@tvdijen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it's fine, I'm not using the ansible deployment.. I've set it manually for now and that's OK..

@MKodde
Copy link
Member Author

@MKodde MKodde commented on d719bca Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tim, I've taken care of this in develop of MW and GW. See this Pivotal chore: https://www.pivotaltracker.com/story/show/160783591

Please sign in to comment.