2751 remove duplicate ids (#2754)

* Dom ID housekeeping

* Update CHANGELOG

CHANGELOG.md

@@ -21,6 +21,9 @@ and this project adheres to
 
 ### Fixed
 
+- Delete user modal no longer uses the same id as the underlying user record.
+  [#2751](https://github.com/OpenFn/lightning/issues/2751)
+
 ## [v2.10.6] - 2024-12-10
 
 ### Added

lib/lightning_web/live/components/user_deletion_modal.ex

@@ -85,7 +85,7 @@ defmodule LightningWeb.Components.UserDeletionModal do
   def render(%{delete_now?: true, has_activity_in_projects?: true} = assigns) do
     ~H"""
     <div>
-      <.modal id={"user-#{@id}"} width="max-w-md" show={true}>
+      <.modal id={"user-#{@id}-delete-modal"} width="max-w-md" show={true}>
         <:title>
           <div class="flex justify-between">
             <span class="font-bold">
@@ -129,7 +129,7 @@ defmodule LightningWeb.Components.UserDeletionModal do
   def render(assigns) do
     ~H"""
     <div>
-      <.modal id={"user-#{@id}"} show={true} width="max-w-md">
+      <.modal id={"user-#{@id}-delete-modal"} show={true} width="max-w-md">
         <:title>
           <div class="flex justify-between">
             <span class="font-bold">