Workflow Diagram: use "forked" dagre #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartc
approved these changes
Jun 5, 2024
taylordowns2000
added a commit
that referenced
this pull request
Jun 5, 2024
* workflow diagram: add basic dagre layout * workflow-dialog: create dummy drag handlers * workflow diagram: create new edge * styling for interactions * workflow-diagram: update drop target validation rules * style tweak * workflow-diagram: prevent invalid edges being created Very suboptimal implementation, but it works * tidy * workfklow-diagram: fix edge positions * workflow-diagram: tweak layout to look more like it did * workflow-diagram: slightly better edge connection styling * workflow-diagram: rough experiment with bezier edges * edit: stub in path deletion button * workflow-diagram: fixes to dagre layout * workflow-diagram: tweak zoom padding * workflow-diagram: give error feedback on hover * workflow-diagram: adjust error styling * workflow-diagram: add controls with autofit toggle * workflow-diagram: tweak highlight styles * workflow-diagram: change error message * workflow-diagram: styling * workflow-diagram: remove old stuff * workflow-diagram: fix an issue where the edge icon prevented the handle getting a click * workflow-diagram: move controls to bottom left * workflow-diagram: simplify and improve error reporting * delete edges (still needs tests & permissions) * tests for edge deletion * center the buttons * handle style, cleanup assigns * remove dupe * unbreak my heart * add dagre vendor file, tidy dependencies (#2178) --------- Co-authored-by: Taylor Downs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies dagre's source dist file, makes a tiny change (basically this), and bundles it in the vendor folder.
It also tidies up some dependencies.
The result is increased stablity of layouts (less chart flipping when adding nodes)