Support providing DiagnosticListener for compiling
#141
Conversation
| } | ||
|
|
||
| @NotNull | ||
| Map<String, byte[]> compileFromJava(@NotNull String className, |
There was a problem hiding this comment.
I have moved this method down a few lines so that all loadFromJava methods are grouped together.
| public Class<?> loadFromJava(@NotNull ClassLoader classLoader, | ||
| @NotNull String className, | ||
| @NotNull String javaCode, | ||
| @Nullable PrintWriter writer) throws ClassNotFoundException { | ||
| @Nullable PrintWriter writer, | ||
| @Nullable DiagnosticListener<? super JavaFileObject> diagnosticListener) throws ClassNotFoundException { |
There was a problem hiding this comment.
Not completely sure about the ? super JavaFileObject; maybe users make assumptions then about the JavaFileObject of the diagnostics, which are actually implementation details of Java-Runtime-Compiler, e.g. the file paths.
| compiler.loadFromJava( | ||
| classLoader, "TestClass", | ||
| // definition with a mandatory warning for deprecated `Date.getDay()` | ||
| "import java.util.Date; class TestClass { int i = new Date().getDay(); }", |
There was a problem hiding this comment.
In this line there is one of the reasons why I changed this test class to create a new CachedCompiler instance for every test method, instead of using CompilerUtils.CACHED_COMPILER and getClass().getClassLoader():
It seems this source code was missing the import java.util.Date, which should normally cause a compiler error. However, previously no compilation error occurred, probably because one of the other test methods had already successfully loaded TestClass and therefore the CachedCompiler#loadFromJava call just returned that class instead of compiling the code.
Marcono1234
force-pushed
the
diagnostics-listener
branch
from
cc106f4 to
e3c49a0
Compare
Resolves #93
Adds a new
CachedCompiler#loadFromJavaoverload withjavax.tools.DiagnosticListenerparameter. The behavior of the existingloadFromJavamethods remains the same.Also adds Javadoc to some of the methods and constructors.
Edit: Sorry I overlooked that there is already #140 for adding Javadoc. Feel free to merge that first and then I can try to resolve conflicts here and maybe make some small Javadoc adjustments.
Any feedback is appreciated!