Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHSL-2023-143, GHSL-2023-144, deny unsigned SAML response #624

Merged
merged 2 commits into from
Jul 18, 2023
Merged

GHSL-2023-143, GHSL-2023-144, deny unsigned SAML response #624

merged 2 commits into from
Jul 18, 2023

Conversation

maximthomas
Copy link
Contributor

No description provided.

@atorralba
Copy link

Have you considered removing the if (samlResponse.isSigned()) check in SAMLUtils.processResponse as well? As it is now it looks a bit like a footgun to me: if someone uses the method somewhere else where validating the signature is a requirement, the same issue that is being fixed here could reproduce.

@maximthomas
Copy link
Contributor Author

@atorralba,
Yes, thank you, it is a good point!

@vharseko vharseko merged commit 7c18543 into OpenIdentityPlatform:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vharseko vharseko Awaiting requested review from vharseko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximthomas @atorralba @vharseko