-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI test to check for relevant completion options in bootstrap.properties and server.env #1205
base: main
Are you sure you want to change the base?
UI test to check for relevant completion options in bootstrap.properties and server.env #1205
Conversation
src/test/java/io/openliberty/tools/intellij/it/SingleModLibertyLSTestCommon.java
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/intellij/it/fixtures/ProjectFrameFixture.java
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/intellij/it/SingleModLibertyLSTestCommon.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anusreelakshmi934 I noticed testCompletionValuesInServerEnv()
and testCompletionValuesInBootstrapProperties()
are mostly copies of each other. We're always trying to reduce and avoid code duplication to make the plugin and tests easier to maintain.
@TrevCraw Wondering what your thoughts are on whether this is sufficient coverage since you opened this issue.
Based on this file - https://github.com/OpenLiberty/liberty-language-server/blob/main/liberty-ls/src/main/java/io/openliberty/tools/langserver/utils/ServerPropertyValues.java#L27 - it looks like LCLS returns a |
So @TrevCraw Is it okay to have two methods since testCompletionValuesInServerEnv() and testCompletionValuesInBootstrapProperties() are mostly copies of each other as pointed out my @mrglavas . |
Fixes #852
testCompletionValuesInServerEnv Video
serverEnv.mov
testCompletionValuesInBootstrapProperties Video
Bootstrap.mov