Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Unused createMavenModule method #1206

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Jan 2, 2025

Fixes #1086
As per the alternatives suggested by Jetbrains

Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link an issue corresponding to this PR

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments.

@anusreelakshmi934 anusreelakshmi934 changed the title Changed the getModuleFilePath() method which is marked as @ApiStatus.Internal Removed the Unused createMavenModule method Jan 7, 2025
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for cleaning this up.

Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anusreelakshmi934 anusreelakshmi934 merged commit 563dd33 into OpenLiberty:main Jan 8, 2025
2 of 3 checks passed
@TrevCraw
Copy link
Contributor

TrevCraw commented Jan 8, 2025

Hi @anusreelakshmi934 , I would recommend updating the PR description to match what was actually changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Internal and Deprecated APIs
5 participants