Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring focus to Liberty toolbar before selecting Config #1208

Closed

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Jan 7, 2025

Fixes #1173

I was not able to reproduce this locally. But From some of the videos, I observed that the configuration is already in a selected state. Clicking elsewhere and then returning to the configuration seems to resolve the issue.
So I have added the changes to first click on the liberty toolbar and then click on the config toolbar.

Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anusreelakshmi934 , I think we should wait for the PR build results and try running multiple OS instances at the same time to confirm if this fix resolves the mentioned issue. If possible, check the feasibility of adding a condition before executing the click on the Liberty toolbar, ensuring the condition is true only when the issue occurs.

@vaisakhkannan
Copy link
Contributor

@anusreelakshmi934 , Staicy attempted to address this issue in the merged PR https://github.com/OpenLiberty/liberty-tools-intellij/pull/1156/files. Try removing her update to the method selectConfigUsingToolbar in this PR and check the builds with only your changes.

@anusreelakshmi934
Copy link
Contributor Author

@vaisakhkannan
I have ran a build across multiple OS with these changes applied. Additionally, I have removed the extra code introduced by @staicy123 and will monitor the results to identify any potential failures.

Regarding the condition check before executing the click on the Liberty toolbar, I believe it’s reasonable to proceed with it. Because The tests using the selectConfigUsingToolbar method occasionally fail in the GHA build, and this change is likely to address that issue I think. Additionally, the click doesn’t introduce any delays or negatively impact other tests, so there’s no downside to including it.

@anusreelakshmi934 anusreelakshmi934 marked this pull request as draft January 7, 2025 15:20
@anusreelakshmi934
Copy link
Contributor Author

This change doesnt resolve the issue. Hence closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated Test Failure: testMultipleConfigEditHistory() Method Fails on some builds of the Cron Job Builds
2 participants