Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lsp4ij to its own repository #547

Merged
merged 17 commits into from
Oct 31, 2023

Conversation

turkeylurkey
Copy link
Member

@turkeylurkey turkeylurkey commented Oct 24, 2023

In build.gradle some dependencies now say "exclude group: 'org.eclipse.lsp4j'". This was needed when using lsp4ij as a plugin and now it is just good hygiene. I added lsp4j as a dependency once again just for clarity even though lsp4ij also includes it.

Fixes #556

turkeylurkey and others added 7 commits October 24, 2023 18:18
Signed-off-by: Michael Glavassevich <[email protected]>
Signed-off-by: Michael Glavassevich <[email protected]>
Signed-off-by: Michael Glavassevich <[email protected]>
Update GitHub action to integrate LSP4iJ into the Liberty Tools for IntelliJ build
DEVELOPING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@turkeylurkey turkeylurkey merged commit bbfc979 into OpenLiberty:main Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use separate LSP4IJ component
3 participants