Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #550 Added custom parameters in start container #553

Conversation

aparnamichael
Copy link
Contributor

Fixes #550 Added custom parameter in start in container

Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK to me. I have two questions.

  1. Do we know what user actions drive the code to flow to LibertyDevStartContainerAction to start the app in a container vs what user actions drive the code to flow to this line in LibertyDevStartAction to start the app in a container?
  2. If you run a custom start command and add parameters (ie. -DhotTests=true) and then run a regular "start in container" command from the dashboard, I am curious what happens (ie. do the parameters from the previous custom start get appended?)

@aparnamichael
Copy link
Contributor Author

aparnamichael commented Oct 31, 2023

@TrevCraw

  1. Do we know what user actions drive the code to flow to LibertyDevStartContainerAction to start the app in a container vs what user actions drive the code to flow to this line in LibertyDevStartAction to start the app in a container?

I have debugged the code to see when the above line is hitting in LibertyDevStartAction class, when we run devc command. Tried from dashboard, run configuration etc.. eveytime it is going to LibertyDevStartContainerAction class.

  1. If you run a custom start command and add parameters (ie. -DhotTests=true) and then run a regular "start in container" command from the dashboard, I am curious what happens (ie. do the parameters from the previous custom start get appended?)

If we run a custom start command with parameters and then run a regular "start in container" command from the dashboard it will run devc command without parameters

@aparnamichael aparnamichael merged commit 67cdbf8 into OpenLiberty:main Oct 31, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVT: Parameters not passed when container checkbox checked
3 participants