-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BC) Removed mysql4 #1470
(BC) Removed mysql4 #1470
Conversation
The PR includes a migration script for that case
I tried it w/ two stores which are around since m1.3/m1.4 - with a good amount of mysql4 resources. The smaller code-base is definitively fine, the larger one needs more testing but I think it'll be fine too. I only used the migration script and didn't change anything manually - so far... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In production for > 1 month
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked for months now.
When there are so many changes involving dozens and even hundreds of files I think it would be best to break them into several PRs. I don't always have the ability to analyze modified files in an IDE and choose to do this task in the browser on my tablet. I understand that everything can be done in a PR but when there are several pieces it is easier to do a reverse if issues occur. I personally agree with this change but I cannot approve it without intensive testing and modify the existing extensions I am using. As a personal opinion such a PR should have a higher number of approvals to avoid further inconveniences and should be merged by a maintainer. |
I like this PR but:
|
For readme, for what version? |
right, we need another PR to modify the README in the v19 branch :-( that sucks... so... let's address it later but we should not forget it (actually we should put it in the release notes too) I guess the "shell/" filename is ok, maybe I'll add a "-pr1470.php" suffix? |
I like just |
This should stay open. |
Sorry, too much conflicts. |
Description
This PR will hurt our feelings 💣 because it remove 99% of Mysql4 PHP class and the deprecatedNode XML node.
This will break 💥 many "outdated" modules.
There is a migration script:
php shell/remove-mysql4.php
It will update all occurrences of mysql4 classes.
Contribution checklist