Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added helper methods to cast Mage::getStoreConfig() to int or float, fixes #3727 #3736

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Added helper methods to cast Mage::getStoreConfig() to int or float, fixes #3727 #3736

merged 3 commits into from
Feb 2, 2024

Conversation

sreichel
Copy link
Contributor

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: Customer Relates to Mage_Customer Component: Adminhtml Relates to Mage_Adminhtml Mage.php Relates to app/Mage.php Component: Admin Relates to Mage_Admin Component: SalesRule Relates to Mage_SalesRule Component: Tax Relates to Mage_Tax Component: Oauth Relates to Mage_Oauth Component: Sendfriend Relates to Mage_Sendfriend Component: Log Relates to Mage_Log Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Rss Relates to Mage_Rss labels Jan 19, 2024
@sreichel sreichel changed the title Added helper methods to cast getStoreConfig to int or float, fixes #3727 Added helper methods to cast Mage::getStoreConfig() to int or float, fixes #3727 Jan 22, 2024
@Sdfendor
Copy link
Contributor

Sdfendor commented Feb 2, 2024 •
edited
Loading

In the light that there is already a method Mage::getStoreConfigFlag(), may I propose to omit the As in the method names of the new methods?

@fballiano fballiano merged commit 88afdb1 into OpenMage:main Feb 2, 2024
17 checks passed
@sreichel sreichel deleted the fix-3727 branch February 2, 2024 12:36
@fballiano fballiano mentioned this pull request Feb 2, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigifab luigifab luigifab approved these changes

@pquerner pquerner pquerner approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: ImportExport Relates to Mage_ImportExport Component: Log Relates to Mage_Log Component: Oauth Relates to Mage_Oauth Component: Reports Relates to Mage_Reports Component: Rss Relates to Mage_Rss Component: SalesRule Relates to Mage_SalesRule Component: Sendfriend Relates to Mage_Sendfriend Component: Tax Relates to Mage_Tax Mage.php Relates to app/Mage.php
Projects
None yet
Milestone
No milestone
6 participants
@sreichel @Sdfendor @kiatng @pquerner @luigifab @fballiano