Fixed null deprecation array_keys in Multishipping.

[kiatng]

Description (*)

Uncaught TypeError: array_keys(): Argument #1 ($array) must be of type array, null given in .../app/code/core/Mage/Checkout/Model/Type/Multishipping.php:618

[sreichel]

Reproducable in core?

[kiatng]

Reproducable in core?

Yes, it happens on /checkout/multishipping/success/:

Uncaught TypeError: array_keys(): Argument #1 ($array) must be of type array, null given in .../app/code/core/Mage/Checkout/Model/Type/Multishipping.php:618
Stack trace:
#0 .../app/code/core/Mage/Checkout/Model/Type/Multishipping.php(618): array_keys()
#1 .../app/code/core/Mage/Checkout/controllers/MultishippingController.php(578): Mage_Checkout_Model_Type_Multishipping->getOrderIds()
#2 .../app/code/core/Mage/Core/Controller/Varien/Action.php(419): Mage_Checkout_MultishippingController->successAction()
#3 .../app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(255): Mage_Core_Controller_Varien_Action->dispatch()
#4 .../app/code/core/Mage/Core/Controller/Varien/Front.php(180): Mage_Core_Controller_Varien_Router_Standard->match()
#5 .../app/code/core/Mage/Core/Model/App.php(358): Mage_Core_Controller_Varien_Front->dispatch()
#6 .../app/Mage.php(748): Mage_Core_Model_App->run()
#7 .../index.php(68): Mage::run()

[sreichel]

I am not sure about adding methods for core/session. Better fix it in Mage_Checkout_Model_Type_Multishipping?

[kiatng]

My opinion is fixing it upstream is better, it's fixing at one source. It'll fix 3rd-party code.

[sreichel]

What the reason for clear parameter?

[kiatng]

See

magento-lts/app/code/core/Mage/Core/Model/Session/Abstract/Varien.php

Lines 299 to 306 in c9a901f

	public function getData($key = '', $clear = false)
	{
	$data = parent::getData($key);
	if ($clear && isset($this->_data[$key])) {
	unset($this->_data[$key]);
	}
	return $data;
	}

And

magento-lts/app/code/core/Mage/Checkout/Block/Multishipping/Success.php

Line 30 in c9a901f

$ids = Mage::getSingleton('core/session')->getOrderIds(true);

$clear is traditionally used to unset the $_data.

[sreichel]

Ignore CS, fixed in #4425