Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template data saved only with default file format #1791

Closed
dg0yt opened this issue Dec 1, 2020 · 0 comments
Closed

Template data saved only with default file format #1791

dg0yt opened this issue Dec 1, 2020 · 0 comments
Milestone
v0.9.5

Comments

@dg0yt
Copy link
Member

dg0yt commented Dec 1, 2020

Steps to reproduce

  1. Save a map in OCD format.
  2. Change template data (scribbling, GPX recording)
  3. Save again.

Actual behaviour

The changed template data is not saved.

Expected behaviour

The template data must be saved.

Configuration

Mapper Version: v0.9.4
@dg0yt dg0yt changed the title Templates saved only with default file format Template data saved only with default file format Dec 1, 2020
@dg0yt dg0yt added this to the v0.9.5 milestone Dec 1, 2020
dg0yt added a commit that referenced this issue Dec 2, 2020
@dg0yt
Exporter: Take care of saving template data
1a1e7da 
Before this change, template data saving was done while saving
template XML configuration. This worked only for the default file
format, and it delayed finishing the writing of the map file until
all modified templates were saved. This behaviour meant increasing
the risk of losing changes to the map, due to crash or forceful
termination (out-of-memory, or Android).

In Exporter::doExport(), it is now easy to catch errors from saving
template data and add messages the to the list of warnings.

Resolves GH-1790 (No error reporting from template saving).
Resolves GH-1791 (Template data saved only for default file format).
dg0yt added a commit that referenced this issue Dec 2, 2020
@dg0yt
TemplateTest: Cover template drawing and saving
ff7fb9a 
Verify that template drawing capability is properly reported
(at least for PNG) and that data changed by drawing is properly
saved when the map is saved.
At the moment, template data saving is known to be missing for
formats other than the default XML format (GH-1791).
dg0yt added a commit that referenced this issue Dec 2, 2020
@dg0yt
Exporter: Take care of saving template data
45b3fff 
Before this change, template data saving was done while saving
template XML configuration. This worked only for the default file
format, and it delayed finishing the writing of the map file until
all modified templates were saved. This behaviour meant increasing
the risk of losing changes to the map, due to crash or forceful
termination (out-of-memory, or Android).

In Exporter::doExport(), it is now easy to catch errors from saving
template data and add messages the to the list of warnings.

Resolves GH-1790 (No error reporting from template saving).
Resolves GH-1791 (Template data saved only for default file format).
dg0yt added a commit that referenced this issue Dec 2, 2020
@dg0yt
TemplateTest: Cover template drawing and saving
9c260f5 
Verify that template drawing capability is properly reported
(at least for PNG) and that data changed by drawing is properly
saved when the map is saved.
At the moment, template data saving is known to be missing for
formats other than the default XML format (GH-1791).
dg0yt added a commit that referenced this issue Dec 2, 2020
@dg0yt
Exporter: Take care of saving template data
17bd91c 
Before this change, template data saving was done while saving
template XML configuration. This worked only for the default file
format, and it delayed finishing the writing of the map file until
all modified templates were saved. This behaviour meant increasing
the risk of losing changes to the map, due to crash or forceful
termination (out-of-memory, or Android).

In Exporter::doExport(), it is now easy to catch errors from saving
template data and add messages the to the list of warnings.

Resolves GH-1790 (No error reporting from template saving).
Resolves GH-1791 (Template data saved only for default file format).
dg0yt added a commit that referenced this issue Dec 3, 2020
@dg0yt
TemplateTest: Cover template drawing and saving
9f45bee 
Verify that the template drawing capability is properly reported
(at least for PNG) and that data changed by drawing is properly
saved when the map is saved.
At the moment, template data saving is known to be missing for
formats other than the default XML format (GH-1791).
dg0yt added a commit that referenced this issue Dec 3, 2020
@dg0yt
Exporter: Take care of saving template data
bfdfbca 
Before this change, template data saving was done while saving
template XML configuration. This worked only for the default file
format, and it delayed finishing the writing of the map file until
all modified templates were saved. This behaviour meant increasing
the risk of losing changes to the map, due to crash or forceful
termination (out-of-memory, or Android).

In Exporter::doExport(), it is now easy to catch errors from saving
template data and add messages the to the list of warnings.

Resolves GH-1790 (No error reporting from template saving).
Resolves GH-1791 (Template data saved only for default file format).
dg0yt added a commit that referenced this issue Dec 3, 2020
@dg0yt
TemplateTest: Cover template drawing and saving
eb79a8d 
Verify that the template drawing capability is properly reported
(at least for PNG) and that data changed by drawing is properly
saved when the map is saved.
At the moment, template data saving is known to be missing for
formats other than the default XML format (GH-1791).
@dg0yt dg0yt closed this as completed in 18202a2 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.5
Development

No branches or pull requests
1 participant
@dg0yt