Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area symbols not behaving properly when rotating map. #1812

Closed
MartinHore opened this issue Dec 22, 2020 · 2 comments
Closed

Area symbols not behaving properly when rotating map. #1812

MartinHore opened this issue Dec 22, 2020 · 2 comments
Assignees
Milestone

Comments

@MartinHore
Copy link

Steps to reproduce

  1. I have area symbols on my map such as 406.1, 408.1 (ISOM 2017) which show direction of easier running. Area setting "adjustable per object" is switched on and I've rotated the pattern to give the correct orientation as measured in the field.
  2. I rotate the whole map (eg to switch alignment from Grid North (OSGB36) to magnetic north - just 2 degrees - , but larger rotations show the problem more obviously).
  3. Area symbol patterns as above should rotate to remain correctly oriented.

Actual behaviour

The above area symbol patterns fail to rotate and are no longer correctly oriented. (As opposed to point symbols such as 110 - elongated small knoll - with "always oriented to north" switched off which do rotate correctly).

Expected behaviour

The area symbol patterns should rotate with the map when "adjustable per object" is switched on.

Configuration

Mapper Version: 9.4
Operating System: Windows 10

Sorry. This seems so simple there must be an obvious solution, or it must have been reported before, but I can't find it. Many thanks. Martin

@dg0yt
Copy link
Member

dg0yt commented Dec 22, 2020

Confirmed with overprinting example. THis is a bug.

@dg0yt dg0yt added this to the v0.9.5 milestone Dec 22, 2020
@MartinHore
Copy link
Author

Thanks Kai. I'm glad I wasn't troubling you for no reason.

I've just found a temporary work around. Re-set the fill rotation angle in area settings to compensate for the map rotation. You have to do it for each affected symbol so it's a bit messy, but quicker than re-orienting every affected feature on the map.

Martin

@dg0yt dg0yt self-assigned this Dec 23, 2020
dg0yt added a commit that referenced this issue Dec 23, 2020
Leave the pattern_origin member in path_object to avoid increasing the
size of class Object, and use a virtual function to dispatch pattern
origin rotation.
Resolves GH-1812 (area symbol patterns not rotated with map).
@dg0yt dg0yt closed this as completed in f12063e Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants