Explicitly list each GDAL vector export format #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't construct the filter string everytime an extension is added, but only when it is actually used. Replace parentheses in the filter name by brackets: parentheses mark the filename patterns.
When QFileDialog is used with option HideNameFilterDetails, the string returning the selected filter does not contain the list of extensions. So the matching by filter must ignore the extensions.
Similar to the OCD format export variants, register a separate export format for each GDAL driver which supports vector data export. Adjust the export dialog to list these formats explicitly. Resolves GH-1778 (List all possible vector formats).
Sometimes we need to add a default extension to a new filename. This change moves existing code from MainWindow to FileFormat. It makes use of the new function for geospatial vector data export. The function is modified to work without manipulating the given list of extensions. It no longer uses the deprecated QRegExp class.
Mapper is limited to GDAL vector export formats which do have registered extensions. This must be reflected by this tool which provides input for editing documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.