Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly display "Xprinter" instead of Xerox for Xprinter devices #506

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

AreaZR
Copy link
Contributor

@AreaZR AreaZR commented Oct 25, 2022

Cups currently displays "Xerox" instead of "Xprinter." This patch fixes this behavior.

Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just adding a space after "XPrint" (and increasing the length by 1 in the string comparison) is enough.

@michaelrsweet michaelrsweet added bug Something isn't working priority-low labels Oct 25, 2022
@michaelrsweet michaelrsweet added this to the v2.4.x milestone Oct 25, 2022
@AreaZR AreaZR force-pushed the XPrinter branch 2 times, most recently from 7572109 to 9bed86b Compare October 26, 2022 01:35
@AreaZR
Copy link
Contributor Author

AreaZR commented Oct 30, 2022

@michaelrsweet Done!

@AreaZR AreaZR force-pushed the XPrinter branch 2 times, most recently from 9988413 to 4ebd169 Compare November 9, 2022 17:48
@AreaZR AreaZR force-pushed the XPrinter branch 2 times, most recently from f4616a0 to 7fafd5c Compare November 17, 2022 14:26
@AreaZR AreaZR force-pushed the XPrinter branch 3 times, most recently from b855617 to 1084637 Compare November 22, 2022 19:36
@AreaZR AreaZR changed the title Correctly display "Xprinter" instead of Xerox Correctly display "Xprinter" instead of Xerox for Xprinter devices Nov 22, 2022
@AreaZR AreaZR force-pushed the XPrinter branch 3 times, most recently from e9a1d76 to aa21f13 Compare November 26, 2022 21:22
@AreaZR AreaZR force-pushed the XPrinter branch 4 times, most recently from 8f9c060 to ebc84b9 Compare December 2, 2022 00:27
CUPS currently displays "Xerox" instead of "Xprinter." This patch fixes this behavior by changing the comparison to "XPrint ", space included.
@michaelrsweet michaelrsweet self-assigned this Jan 17, 2023
@michaelrsweet michaelrsweet merged commit 6756bf7 into OpenPrinting:master Jan 17, 2023
@AreaZR AreaZR deleted the XPrinter branch January 26, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants