replaced PointerHolder with shared_ptr #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. Did you compile the code? Does it completely compile without producing any errors or warnings except the PointerHolder warnings? |
|
Yes I did compile it on Ubuntu Lunar, the only warnings are PointerHolder warnings |
|
Ran some filters for testing and all seems to be OK. Thank you very much. |
|
@ShivamIITK21 @tillkamppeter when I used the make command it gives me this error.I update qpdf but the newest version is (10.6.3-1). can you please tell me how to update qpdf to v12 because I deleted the old repo of libcupsfilters and I have to install libcupsfilters now from the updated repo but it gives me the above error. |
|
You can build qpdf v11 from source, https://github.com/qpdf/qpdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointerHolder is deprecated in the qpdf v11, getting replaced with std::shared_ptr. Warnings should be fixed with qpdf v12 onwards.