Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #7

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

zdohnal
Copy link
Member

@zdohnal zdohnal commented Jan 31, 2023

Avahi, Glib, Freetype and Zlib are used in other projects or removed as whole.

ZLIB is now required only for libppd.
Avahi is now used only in cups-browsed.
We don't use freetype API since dropping pdftoopvp, we don't have to
require it explicitly. Freetype is fontconfig's dependency, so
fontconfig should bring in Freetype (since Freetype is used for building
the fontconfig...)
@tillkamppeter tillkamppeter merged commit b2ab2b1 into OpenPrinting:master Jan 31, 2023
@tillkamppeter
Copy link
Member

Thanks a lot, these dependencies got so many with the years, it is easy to overlook some of them ...

@zdohnal
Copy link
Member Author

zdohnal commented Jan 31, 2023

Np! :) I write comments for BuildRequires in my spec file, so I can easier track what is no longer needed - maybe do a bullet list in INSTALL file for dependencies with explanation why they are needed?

It won't prevent the situation when you remove a feature and don't read the INSTALL, but at least maintainers can sometimes check the deps and when they see the dep in INSTALL and git says the feature which needed the dependency is gone, they can report it.

@tillkamppeter
Copy link
Member

Could you add these comments which you put into BuildRequires also to an appropriate place in the source code documentations of the OpenPrinting repos, into README.md or INSTALL or so? Thanks in advance.

zdohnal added a commit to zdohnal/libcupsfilters that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants