Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-spacetimechart: add occupancy blocks layer #619

Merged
merged 1 commit into from
Oct 14, 2024
Merged

ui-spacetimechart: add occupancy blocks layer #619

merged 1 commit into from
Oct 14, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Oct 6, 2024

@Akctarus Akctarus changed the title ui-spacetimechart: add occupation blocs layer ui-spacetimechart: add occupancy blocs layer Oct 7, 2024
@Akctarus Akctarus force-pushed the tmn/spacetimechart/occupation-blocs-layer branch 6 times, most recently from 564819a to bc75321 Compare October 8, 2024 10:45
@Akctarus Akctarus marked this pull request as ready for review October 8, 2024 10:45
@Akctarus Akctarus requested a review from a team as a code owner October 8, 2024 10:45
@Akctarus Akctarus requested review from emersion and clarani October 8, 2024 13:36
@emersion
Copy link
Member

emersion commented Oct 8, 2024 •
edited
Loading

"Bloc" seems… very French :P

Should it be "block"? Or is there a better English translation for "bloc d'occupation"?

Edit: reading the docs, seems like "block" is the right word to use here.

@emersion
Copy link
Member

emersion commented Oct 8, 2024

I'd also recommend not doing the same mistake I did :P #624

@emersion
Copy link
Member

emersion commented Oct 8, 2024

Do we have a mockup for this?

@Akctarus
Copy link
Contributor Author

Akctarus commented Oct 8, 2024

Do we have a mockup for this?

Yes :
336398851-a2fe7587-e43f-4591-8add-88454b3bcaf4

and : https://www.sketch.com/s/bcbac4ff-7f74-4f1a-9e10-08d115c47ed8/p/C0FA571F-D55C-40A1-B0E0-B61D135726CD/canvas

@Akctarus Akctarus requested review from emersion and Yohh October 9, 2024 13:49
@Akctarus Akctarus force-pushed the tmn/spacetimechart/occupation-blocs-layer branch 5 times, most recently from 9ea8896 to d87011a Compare October 11, 2024 08:36
emersion
emersion reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two minor comments, LGTM!

@Akctarus Akctarus force-pushed the tmn/spacetimechart/occupation-blocs-layer branch from 428248e to 6dab328 Compare October 11, 2024 09:09
@emersion emersion changed the title ui-spacetimechart: add occupancy blocs layer ui-spacetimechart: add occupancy blocks layer Oct 11, 2024
@clarani clarani mentioned this pull request Oct 11, 2024
Merged
@Akctarus Akctarus requested a review from Math-R October 11, 2024 12:49
@Akctarus Akctarus force-pushed the tmn/spacetimechart/occupation-blocs-layer branch from 3443c31 to 330d65c Compare October 14, 2024 13:17
Math-R
Math-R approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Akctarus Akctarus added this pull request to the merge queue Oct 14, 2024
Merged via the queue into dev with commit 2070ca5 Oct 14, 2024
6 checks passed
@Akctarus Akctarus deleted the tmn/spacetimechart/occupation-blocs-layer branch October 14, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Math-R Math-R Math-R approved these changes

@Yohh Yohh Yohh approved these changes

@emersion emersion emersion approved these changes

@clarani clarani Awaiting requested review from clarani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Display occupancy blocks in GET
4 participants
@Akctarus @emersion @Yohh @Math-R