front: Fix train displaying as not honored despite respecting times a…

…nd stops

The bug was caused by attempting to match the schedule constraint data with the train's arrival times at each point along its route.
The first table (`trainSchedule.schedule`) contains only points with time constraints, while the second table (`trainSummary.path_item_times_final`) includes the train's arrival times for all intermediate points, including those without time constraints.
So, matching the indices between the two tables doesn't work because the first table skips points that aren't constrained.

front/src/applications/operationalStudies/utils.ts

@@ -235,12 +235,17 @@ export const isScheduledPointsNotHonored = (
   }
 
   if (!trainSchedule.schedule) return false;
-  return trainSchedule.schedule.some((schedule, index) => {
+  return trainSchedule.schedule.some((schedule) => {
     if (!schedule.arrival) return false;
-    // need to add +1 because origin will never be in schedules
+    const matchindIndex = trainSchedule.path.findIndex((pathItem) => pathItem.id === schedule.at);
+    if (matchindIndex === -1) {
+      throw new Error(
+        `No matching index found for schedule ${schedule} on trainSchedule ${trainSchedule}`
+      );
+    }
     const arrivalTimeInMs = sToMs(ISO8601Duration2sec(schedule.arrival));
     return (
-      Math.abs(arrivalTimeInMs - trainSummary.path_item_times_final[index + 1]) >=
+      Math.abs(arrivalTimeInMs - trainSummary.path_item_times_final[matchindIndex]) >=
       ARRIVAL_TIME_ACCEPTABLE_ERROR_MS
     );
   });