Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path projection endpoint #7210

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add path projection endpoint #7210

merged 3 commits into from
Apr 25, 2024

Conversation

flomonster
Copy link
Contributor

close #6858

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.78245% with 293 lines in your changes are missing coverage. Please review.

Project coverage is 28.93%. Comparing base (11da135) to head (8fd8f3e).

Files Patch % Lines
editoast/src/views/v2/train_schedule/projection.rs 34.86% 213 Missing ⚠️
editoast/src/views/v2/train_schedule.rs 8.92% 51 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 90.00% 8 Missing ⚠️
editoast/src/core/v2/pathfinding.rs 89.13% 5 Missing ⚠️
editoast/src/core/v2/simulation.rs 44.44% 5 Missing ⚠️
editoast/src/views/v2/path/projection.rs 98.19% 5 Missing ⚠️
editoast/src/core/v2/signal_updates.rs 25.00% 3 Missing ⚠️
editoast/src/views/v2/path/pathfinding.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7210      +/-   ##
============================================
+ Coverage     28.73%   28.93%   +0.20%     
  Complexity     2004     2004              
============================================
  Files          1123     1126       +3     
  Lines        138057   138733     +676     
  Branches       2684     2684              
============================================
+ Hits          39672    40148     +476     
- Misses        96788    96988     +200     
  Partials       1597     1597
Flag Coverage Δ
core 78.37% <ø> (ø)
editoast 72.04% <60.90%> (-0.08%) ⬇️
front 9.32% <90.00%> (+0.04%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the fam/train-schedule-projection branch 3 times, most recently from 860af84 to 1da28d7 Compare April 17, 2024 15:37
@flomonster flomonster force-pushed the fam/train-schedule-projection branch 5 times, most recently from 59c633f to 46a589f Compare April 23, 2024 21:19
@flomonster flomonster marked this pull request as ready for review April 23, 2024 21:19
@flomonster flomonster requested a review from a team as a code owner April 23, 2024 21:19
@flomonster flomonster force-pushed the fam/train-schedule-projection branch from 46a589f to 4755490 Compare April 24, 2024 07:07
@flomonster flomonster force-pushed the fam/train-schedule-projection branch 3 times, most recently from b57a35c to b56cd4d Compare April 24, 2024 09:28
leovalais
leovalais reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for walking me through this PR, that really helped. I tried to read everything carefully and came up with a few ways I believe would improve readability. I'll make a second batch of comments for minor things and nitpicks.

It's great having all these tests, they also really help understanding what happens 🤩

editoast/src/core/v2/simulation.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule/projection.rs Outdated Show resolved Hide resolved
leovalais
leovalais reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As promised, a few comments about details.

editoast/src/views/v2/train_schedule/projection.rs Show resolved Hide resolved
editoast/src/views/v2/train_schedule/projection.rs Show resolved Hide resolved
editoast/src/views/v2/train_schedule/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/train_schedule/projection.rs Outdated Show resolved Hide resolved
editoast/src/core/v2/simulation.rs Show resolved Hide resolved
@flomonster flomonster force-pushed the fam/train-schedule-projection branch from 246eb52 to cd4bf2e Compare April 24, 2024 19:48
@younesschrifi younesschrifi force-pushed the fam/train-schedule-projection branch 2 times, most recently from 7f245ea to c3e8590 Compare April 24, 2024 21:16
@flomonster flomonster force-pushed the fam/train-schedule-projection branch 2 times, most recently from d020390 to 53dc96a Compare April 24, 2024 22:16
@flomonster flomonster requested a review from leovalais April 25, 2024 07:41
@flomonster flomonster force-pushed the fam/train-schedule-projection branch 2 times, most recently from 292462e to 6821788 Compare April 25, 2024 09:09
leovalais
leovalais requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have spotted a regression compared to yesterday in PathProjection::get_location

editoast/src/core/v2/simulation.rs Show resolved Hide resolved
editoast/src/core/v2/pathfinding.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
editoast/src/views/v2/path/projection.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the fam/train-schedule-projection branch from bda2161 to 26d8226 Compare April 25, 2024 14:02
@younesschrifi younesschrifi force-pushed the fam/train-schedule-projection branch from 26d8226 to 2a926d0 Compare April 25, 2024 14:17
@younesschrifi younesschrifi force-pushed the fam/train-schedule-projection branch from 8fd8f3e to 00a48c0 Compare April 25, 2024 14:56
@younesschrifi younesschrifi added this pull request to the merge queue Apr 25, 2024
Merged via the queue into dev with commit c2a5fa9 Apr 25, 2024
17 checks passed
@younesschrifi younesschrifi deleted the fam/train-schedule-projection branch April 25, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi left review comments

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS2: Add editoast project path endpoint
4 participants
@flomonster @codecov-commenter @leovalais @younesschrifi