Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add a RailJSON builder and remove the old builder #7277

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

multun
Copy link
Contributor

@multun multun commented Apr 19, 2024

Fix part of #7056

@multun multun force-pushed the core/infra_load_refactor branch 2 times, most recently from 89c91b6 to 5b5d931 Compare April 19, 2024 09:15
@multun multun force-pushed the kt-railjson-builder branch from a2ec63f to 6803a20 Compare April 19, 2024 09:22
@multun multun force-pushed the core/infra_load_refactor branch from 5b5d931 to ebbeb01 Compare April 19, 2024 11:53
@multun multun force-pushed the kt-railjson-builder branch from 6803a20 to 89bbbe8 Compare April 19, 2024 11:55
@multun multun changed the title core: add a RailJSON builder core: add a RailJSON builder and remove the old builder Apr 19, 2024
@multun multun marked this pull request as ready for review April 19, 2024 11:56
@multun multun requested a review from a team as a code owner April 19, 2024 11:56
@multun multun requested a review from Erashin April 19, 2024 11:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 18.01%. Comparing base (00215fe) to head (5c65b88).

Files Patch % Lines
...n/fr/sncf/osrd/railjson/builder/RJSInfraBuilder.kt 80.00% 33 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7277       +/-   ##
=============================================
- Coverage     28.39%   18.01%   -10.39%     
+ Complexity     2016     2006       -10     
=============================================
  Files          1134      895      -239     
  Lines        140128   112333    -27795     
  Branches       2743     2707       -36     
=============================================
- Hits          39792    20238    -19554     
+ Misses        98706    90477     -8229     
+ Partials       1630     1618       -12     
Flag Coverage Δ
core 78.21% <80.00%> (+0.83%) ⬆️
editoast ?
front 9.14% <ø> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multun multun force-pushed the core/infra_load_refactor branch from ebbeb01 to f2d4583 Compare April 19, 2024 13:30
@multun multun requested review from a team as code owners April 19, 2024 13:30
@multun multun force-pushed the core/infra_load_refactor branch from f2d4583 to 8873c87 Compare April 19, 2024 13:36
@multun multun removed request for a team and Erashin April 19, 2024 13:53
@multun multun force-pushed the kt-railjson-builder branch from 89bbbe8 to d04a0e2 Compare April 19, 2024 13:54
Base automatically changed from core/infra_load_refactor to dev April 19, 2024 14:17
@multun multun force-pushed the kt-railjson-builder branch from d04a0e2 to b93864c Compare April 19, 2024 14:33
@multun multun force-pushed the kt-railjson-builder branch from b93864c to 5c65b88 Compare April 19, 2024 14:34
@multun multun added this pull request to the merge queue Apr 19, 2024
Merged via the queue into dev with commit e67fe5f Apr 19, 2024
17 checks passed
@multun multun deleted the kt-railjson-builder branch April 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants