Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, editoast: remove schematic #7356

Merged
merged 2 commits into from
May 23, 2024
Merged

core, editoast: remove schematic #7356

merged 2 commits into from
May 23, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented May 2, 2024

Fixes #6789.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 29.39%. Comparing base (afc1c50) to head (d5dc5ad).
Report is 16 commits behind head on dev.

Files Patch % Lines
editoast/src/views/infra/lines.rs 25.00% 3 Missing ⚠️
front/src/common/Map/Search/MapSearchLine.tsx 0.00% 2 Missing ⚠️
front/src/reducers/editor/thunkActions.ts 0.00% 1 Missing ⚠️
...r/railjson_generator/schema/infra/make_geo_data.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7356      +/-   ##
============================================
+ Coverage     29.36%   29.39%   +0.02%     
  Complexity     2012     2012              
============================================
  Files          1177     1182       +5     
  Lines        145975   146032      +57     
  Branches       2871     2872       +1     
============================================
+ Hits          42867    42920      +53     
- Misses       101423   101427       +4     
  Partials       1685     1685              
Flag Coverage Δ
core 75.13% <ø> (+<0.01%) ⬆️
editoast 72.38% <83.33%> (+0.04%) ⬆️
front 9.78% <25.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <50.00%> (ø)
tests 84.23% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo force-pushed the yk/remove-schematic branch 2 times, most recently from 1ea7aae to b47d497 Compare May 22, 2024 09:41
@Khoyo Khoyo marked this pull request as ready for review May 22, 2024 09:42
@Khoyo Khoyo requested review from a team as code owners May 22, 2024 09:42
@Khoyo Khoyo requested a review from eckter May 22, 2024 09:42
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, I found 2 more occurrences of sch or schematic:

  • in injectGeometry (trackEdition/utils.ts)
  • in loadDataModel (editor/thunkActions.ts)

front/src/reducers/osrdconf/infra_schema.json Show resolved Hide resolved
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core and tests

@Khoyo Khoyo force-pushed the yk/remove-schematic branch from 685ec6c to e5fd578 Compare May 22, 2024 13:54
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Khoyo added 2 commits May 23, 2024 06:11
Schematic geometry was not available to use in the frontend for a long
time, and we do not plan to re enable it in its current form.
Now that schematic has been removed, Zone is simply a single BoundingBox
@Khoyo Khoyo force-pushed the yk/remove-schematic branch from e5fd578 to d5dc5ad Compare May 23, 2024 04:11
@Khoyo Khoyo enabled auto-merge May 23, 2024 04:13
@Khoyo Khoyo added this pull request to the merge queue May 23, 2024
Merged via the queue into dev with commit 959ed9d May 23, 2024
17 checks passed
@Khoyo Khoyo deleted the yk/remove-schematic branch May 23, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete schematic geometry from the application
5 participants