-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core, editoast: remove schematic #7356
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7356 +/- ##
============================================
+ Coverage 29.36% 29.39% +0.02%
Complexity 2012 2012
============================================
Files 1177 1182 +5
Lines 145975 146032 +57
Branches 2871 2872 +1
============================================
+ Hits 42867 42920 +53
- Misses 101423 101427 +4
Partials 1685 1685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1ea7aae
to
b47d497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good, I found 2 more occurrences of sch or schematic:
- in injectGeometry (trackEdition/utils.ts)
- in loadDataModel (editor/thunkActions.ts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for core and tests
685ec6c
to
e5fd578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Schematic geometry was not available to use in the frontend for a long time, and we do not plan to re enable it in its current form.
Now that schematic has been removed, Zone is simply a single BoundingBox
e5fd578
to
d5dc5ad
Compare
Fixes #6789.