Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use endpoint's uri for span's name #7366

Merged
merged 1 commit into from
May 3, 2024

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented May 2, 2024

Before:

image

After:

image

Should much easier to dig through the traces of the endpoints. I just hope it works as expected for Datadog.

@woshilapin woshilapin requested a review from flomonster May 2, 2024 19:41
@woshilapin woshilapin requested a review from a team as a code owner May 2, 2024 19:41
@woshilapin woshilapin requested a review from eckter May 2, 2024 19:41
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.14%. Comparing base (70e6bdc) to head (44e4bcc).
Report is 1 commits behind head on dev.

Files Patch % Lines
.../src/main/java/fr/sncf/osrd/cli/TkOpenTelemetry.kt 0.00% 3 Missing ⚠️
core/src/main/java/fr/sncf/osrd/cli/TkDataDog.kt 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7366      +/-   ##
============================================
+ Coverage     29.12%   29.14%   +0.02%     
  Complexity     2016     2016              
============================================
  Files          1141     1141              
  Lines        139912   139971      +59     
  Branches       2769     2769              
============================================
+ Hits          40744    40790      +46     
- Misses        97552    97565      +13     
  Partials       1616     1616              
Flag Coverage Δ
core 76.29% <0.00%> (-0.03%) ⬇️
editoast 72.00% <ø> (+0.02%) ⬆️
front 9.36% <ø> (+<0.01%) ⬆️
gateway 2.43% <ø> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a formatting issue, other than that LGTM

@woshilapin woshilapin force-pushed the wsl/feat/core-telemetry-named-endpoints branch from b3168f3 to c2e50aa Compare May 3, 2024 08:49
@woshilapin woshilapin enabled auto-merge May 3, 2024 08:49
@woshilapin woshilapin force-pushed the wsl/feat/core-telemetry-named-endpoints branch from c2e50aa to 44e4bcc Compare May 3, 2024 11:19
@woshilapin woshilapin added this pull request to the merge queue May 3, 2024
Merged via the queue into dev with commit bd0f793 May 3, 2024
17 checks passed
@woshilapin woshilapin deleted the wsl/feat/core-telemetry-named-endpoints branch May 3, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants