Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt route calculation #7475

Merged
merged 1 commit into from
May 22, 2024
Merged

Adapt route calculation #7475

merged 1 commit into from
May 22, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented May 22, 2024

Description

close https://github.com/osrd-project/osrd-confidential/issues/496

Allow implicit nodes when they have one group.

Note

We still have a nonambiguous description of the route.
We don't need a migration since it's optional to provide implicit node positions.

Motivation

We can now split tracks in the editor. This creates a new "track section link" and breaks a lot of routes doing so. We could:

  • Lookup for all routes that should be updated
  • Change how routes are built in editoast and core to allow implicit nodes with only one group/config.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.81%. Comparing base (afc1c50) to head (b376162).
Report is 1 commits behind head on dev.

Current head b376162 differs from pull request most recent head 1af7050

Please upload reports for the commit 1af7050 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7475      +/-   ##
============================================
- Coverage     29.36%   24.81%   -4.55%     
============================================
  Files          1177      863     -314     
  Lines        145975   132784   -13191     
  Branches       2871      961    -1910     
============================================
- Hits          42867    32953    -9914     
+ Misses       101423    98877    -2546     
+ Partials       1685      954     -731     
Flag Coverage Δ
core ?
editoast 72.32% <100.00%> (-0.02%) ⬇️
front 9.79% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/adapt-route-calculation branch from e9042f2 to b376162 Compare May 22, 2024 09:10
@flomonster flomonster marked this pull request as ready for review May 22, 2024 09:10
@flomonster flomonster requested review from a team as code owners May 22, 2024 09:10
@flomonster flomonster requested review from Khoyo, multun and bougue-pe and removed request for Khoyo May 22, 2024 09:10
@flomonster flomonster enabled auto-merge May 22, 2024 09:18
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@flomonster flomonster force-pushed the fam/adapt-route-calculation branch from b376162 to 1af7050 Compare May 22, 2024 09:26
@flomonster flomonster added this pull request to the merge queue May 22, 2024
Merged via the queue into dev with commit 9fd2121 May 22, 2024
17 checks passed
@flomonster flomonster deleted the fam/adapt-route-calculation branch May 22, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants