-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve batch pathfinding performances #8035
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8035 +/- ##
============================================
- Coverage 28.07% 28.06% -0.01%
Complexity 2075 2075
============================================
Files 1288 1289 +1
Lines 157729 157764 +35
Branches 3121 3121
============================================
- Hits 44283 44281 -2
- Misses 111569 111606 +37
Partials 1877 1877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice optimization !
(This patch has 0% coverage 👀)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly naming considerations. In general, this should help a lot to be more gentle on the DB, so nice work!
2a924af
to
366cc35
Compare
Reduce number of call perform to the database
366cc35
to
b0214a2
Compare
Description
This PR tries to improve calls to
simulation_summary
when train schedules are not cached to redis.--no-cache
optionBenchmark
simulation_summary
endpoint on 30 train schedules timetable (all valid)--no-cache
option is enabledBefore
Time: 1.15s
Number of DB queries: 236
After
Time: 937ms
Number of DB queries: 5